[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: changes for next PETSc release
- To: petsc-dev@xxxxxxxxxxx
- Subject: Re: changes for next PETSc release
- From: "Aron Ahmadia" <aja2111@xxxxxxxxxxxx>
- Date: Mon, 17 Mar 2008 11:27:54 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=hrJQEK4HStvmzpjzslJV+iUyvrnyGtAvtaEQYmEo1yY=; b=dioC3Idr+JCEvrCI3WqEZ28rr6EbwbvLlGkzI87rtOwBVwEFKlWqtxOetAOt2k/zrIg8wNVqM69gXmta5ANxpl+OYtHW3LgEphdc0LSs6s/+7uR0i4lrEtzL45Y69I2T6c8aAsc8pJBzw9W2ouIaqwsZ41WfQK7O49NS2zTlP6g=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=GRvs/npRchQ63NmqH3cCwnBUjGUpJdjFVsxF4Zo/fqbJzjBuIT6n6Fhh6JyDRMvZnFmU4lgczjSJK5U1wuIzc6JIqCJMuWONltva0DNGZXo7TGOuF1oB0rrInS2bpxxNl4Qj1pr8f/9UAQyB+XiS2+KNM5WiEZhxhFBuqkXp+vE=
- In-reply-to: <a9f269830803170823v8961bcdoa9d33adc3eb76ca2@mail.gmail.com>
- References: <E9103C03-5EB9-406C-AA6E-AA918A30C2D4@mcs.anl.gov> <a9f269830803170823v8961bcdoa9d33adc3eb76ca2@mail.gmail.com>
- Reply-to: petsc-dev@xxxxxxxxxxx
- Sender: owner-petsc-dev@xxxxxxxxxxx
Can the namespace issue be fixed with some macro magic?
#ifdef UNIQUE_PETSC_NAMESPACE
#define Mat PetscMat
#endif
...
...
#undef Mat
This seems like it would satisfy both parties, and a compiler/build
flag could uniqueify the namespace if needed.
~A
On Mon, Mar 17, 2008 at 11:23 AM, Matthew Knepley <knepley@xxxxxxxxx> wrote:
> On Sun, Mar 16, 2008 at 7:38 PM, Barry Smith <bsmith@xxxxxxxxxxx> wrote:
> >
> >
> > There are two significant changes I'd like to see before the
> > next PETSc release:
> >
> > 1) remove the overly complicated (from a user perspective) matrix
> > subclassing for the various external
> > matrix solver packages and replace with MatSolverSetType() -
> > mat_solver_type <type> that simply
> > flips the various factorization/solver functions with those
> > requested and
>
> This seems not too hard. Just a layer on top to run the code a user must
> run now.
>
>
> > 2) properly name-space PETSc by putting a Petsc in front of all PETSc
> > objects, function names etc
> > (this will require changing a few names also to keep them below
> > the 32 character limit). This will
> > be very painful change for some users who are not comfortable
> > ever changing code, hence I hesitate
> > to do it, but it is the right thing to do and should have been
> > done originally.
>
> I guess I still do not see the need for this. NIMROD is a not a sufficient
> driver in my mind. If we really want namespaces, use a real language that
> has namespaces. There are plenty. If we are still using C, I say we stick
> with the old division. The imposition of this much pain on the overwhelming
> majority of users seems unjustified.
>
> Namespaces issues can be trivially fixed in say C++, which we should do.
>
> Matt
>
>
>
> > Maybe we can do a release in around a couple of months, it would
> > be 2.4
> >
> > Barry
> >
> >
> >
>
>
>
> --
> What most experimenters take for granted before they begin their
> experiments is infinitely more interesting than any results to which
> their experiments lead.
> -- Norbert Wiener
>
>