[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: changing MatSetUp()
- To: petsc-dev@xxxxxxxxxxx
- Subject: Re: changing MatSetUp()
- From: "Matthew Knepley" <knepley@xxxxxxxxx>
- Date: Tue, 23 Oct 2007 15:13:01 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=Pvh9iRlPvRs4ucmzC8eDlMY9De0IHGerzj3829FLlqw=; b=BsuCStZM0qhg0MMFeDJloLrMSf4PY1mV0Qg55KRXCgkwELMXwNOaNpAispSROUQi4UL2Vhir9GHWTN00QO9/CcRuY9Wl/LGne1yyZyPaoODDzCAZKDug9WHRbEwOliwbk6J1S1i2YNdMaFQ2ildUWtcZzdwjEzBQNuwvREAStkw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rAXAk02gMBHoE7XgH8Ry9xlpF4lKnzQHxg1WdQqZJlOjIUGiJNDBh1XFAl2hu4vjUhV0+sJWgNkyHUAcxXiUKBqTeh6aWIBymVcBygwusRukZGZOzrvgcXpFeT+U4vVWuMw+pIw5R/BRFIPkvYCt36eNqKelJKExksd5dkCIQ9k=
- In-reply-to: <e7ba66e40710231307i27d69edbm14d9961a363be449@mail.gmail.com>
- References: <e7ba66e40710231307i27d69edbm14d9961a363be449@mail.gmail.com>
- Reply-to: petsc-dev@xxxxxxxxxxx
- Sender: owner-petsc-dev@xxxxxxxxxxx
I am not sure about this. MatSetFromOptions() is intentionally optional,
and should not be bundled in a method not intended to be optional.
Matt
On 10/23/07, Lisandro Dalcin <dalcinl@xxxxxxxxx> wrote:
> After greping, it seems that MatSetUp() is not used in all 'petsc-dev'
> repo. If there is no objections (Barry?), I will change it (by
> reverting inner calls order) to do the following:
>
> PetscErrorCode MatSetUp(Mat A)
> {
> MatSetFromOptions(A);
> MatSetUpPreallocation(A);
> }
>
> As I mailed some time ago, there is no point of calling
> MatSetUpPreallocation() if the matrix type was not set.
>
>
> --
> Lisandro Dalcín
> ---------------
> Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
> Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
> Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
> Tel/Fax: +54-(0)342-451.1594
>
>
--
What most experimenters take for granted before they begin their
experiments is infinitely more interesting than any results to which
their experiments lead.
-- Norbert Wiener