[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: leaks in multiple calls for preallocating AIJ matrices

To: petsc-dev@xxxxxxxxxxx
Subject: Re: leaks in multiple calls for preallocating AIJ matrices
From: "Lisandro Dalcin" <dalcinl@xxxxxxxxx>
Date: Tue, 23 Oct 2007 16:19:53 -0300
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=3cenAxs8p5LpzS3zi4qycWeybYMdPig9DQVCXVmVlMs=; b=bVcTN8i8zYb1DfQ5awK7AJWv3Gm3Lw2XZSKfLMYKP4HDwwKP8OArJm1sLSYpVuKPCmiFPUMx0VVgo3OIiM3bJGbxLeTeuy9WxuXBBujvWlwXzAWVL3waJR7F6gFhTssAFhXL4yQSXXJgLdq5vEGS4yqFru403ihjpz+iAT+QNvY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XZfkEz4EK43eJm0iUpT/+d0fTm8HqZOPTIlj/K8xMGysYkRqd/jZvU70wBz5ymaX/KMEtIE4wX7A6DL+XDSFCiyZP5ZeNSRxi3mGN96ZluciB5nlQYuVIkm9dv6oGeky5hwJcUOfO3HAVbUD5dH2j044aXLH3RQjEVfvvzbZpQQ=
In-reply-to: <e7ba66e40710231216j6958676do2b80625749a89053@mail.gmail.com>
References: <e7ba66e40710221135u28088783q6cdc917765a559db@mail.gmail.com> <Pine.OSX.4.64.0710231400221.14706@bsmith.mcs.anl.gov> <e7ba66e40710231216j6958676do2b80625749a89053@mail.gmail.com>
Reply-to: petsc-dev@xxxxxxxxxxx
Sender: owner-petsc-dev@xxxxxxxxxxx

Of course, the space that can be reutilized are the arrays with
preallocation info, not the ones with actual matrix entries (a,i,j).

On 10/23/07, Lisandro Dalcin <dalcinl@xxxxxxxxx> wrote:
> Looking at the actual code, it seems there is not need to actually
> reallocate space, the same space can be reutilized. Do you think I'm
> missing something?
>
> And please, tell me: should I fix this in release-2.3.3? I believe
> this will not impact previous user code in any way.
>
>
>
> On 10/23/07, Barry Smith <bsmith@xxxxxxxxxxx> wrote:
> >
> >   Lisandro,
> >
> >     I agree we should support multiple calls (or at worst generate an
> > error on the second call). Presumably the specific
> > MatXXXYYYSetPreallocation() routines would simply free up their
> > current points and then (as it does now) allocate the appropriate new
> > space. Feel free to add this.
> >
> >    Barry
> >
> >
> > On Mon, 22 Oct 2007, Lisandro Dalcin wrote:
> >
> > > Currently, making sucessive calls for preallocating AIJ matrices seem
> > > to originate memory leaks.
> > >
> > > How should this be corrected? I would prefer that this is a valid
> > > operation, and fix appropriate routines to deallocate/reuse previous
> > > memory, and set the new user-specified preallocation data.
> > >
> > > Other point: should this fix go to release-2.3.3?
> > >
> > >
> > >
> >
> >
>
>
> --
> Lisandro Dalcín
> ---------------
> Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
> Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
> Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
> PTLC - Güemes 3450, (3000) Santa Fe, Argentina
> Tel/Fax: +54-(0)342-451.1594
>


-- 
Lisandro Dalcín
---------------
Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
PTLC - Güemes 3450, (3000) Santa Fe, Argentina
Tel/Fax: +54-(0)342-451.1594

Follow-Ups:
- Re: leaks in multiple calls for preallocating AIJ matrices
  - From: Barry Smith

References:
- leaks in multiple calls for preallocating AIJ matrices
  - From: Lisandro Dalcin
- Re: leaks in multiple calls for preallocating AIJ matrices
  - From: Barry Smith
- Re: leaks in multiple calls for preallocating AIJ matrices
  - From: Lisandro Dalcin

Prev by Date: Re: leaks in multiple calls for preallocating AIJ matrices
Next by Date: changing MatSetUp()
Previous by thread: Re: leaks in multiple calls for preallocating AIJ matrices
Next by thread: Re: leaks in multiple calls for preallocating AIJ matrices
Index(es):
- Date
- Thread