[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: renaming in PC
- To: petsc-dev@xxxxxxxxxxx
- Subject: Re: renaming in PC
- From: "Lisandro Dalcin" <dalcinl@xxxxxxxxx>
- Date: Tue, 9 Oct 2007 17:32:27 -0300
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=d6m3v7am+IIf1Mvrgv35v87fGTQJPQv+dGzonxGGkoQ=; b=tLksd2nvfdRwi1IcnvphcZramEjuItU1DYVuO6zLmLpyrZA1yOuBtE3ZWJ7hu8axslo5GDkNlhtZofP6i84T+WehUIo89Du2ex/xDgUzENfnvrFBvU1/8jhY400p8Et9GfMamdzpHRBuYEeelU7ghtqwTU8yIR4hv/9qsCycH/c=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RbUSL1HeiEkdJUSL+rxoRAP9anYCe5oU5D3qGR8dpmISVtdjLXo9fd8EdmkLI557nYYb8d1w89YR2lGAFsGMtb1n2gk3QT6wzxEap+1GjzBi63A+SW15HurjnHR++f4p+06SgqzfLmj3nM5y3ESXsElPyUXrrLcjmU56uDdxGEY=
- In-reply-to: <Pine.OSX.4.64.0710091515560.224@bsmith.local>
- References: <e7ba66e40710091312t35b6fddw54ea83aa56048c5d@mail.gmail.com> <Pine.OSX.4.64.0710091515560.224@bsmith.local>
- Reply-to: petsc-dev@xxxxxxxxxxx
- Sender: owner-petsc-dev@xxxxxxxxxxx
Good point...
So we should rename
PetscErrorCode PCHasApplyTranspose(PC,PetscTruth*)
to
PetscErrorCode PCApplyTransposeExists(PC,PetscTruth*)
???
On 10/9/07, Barry Smith <bsmith@xxxxxxxxxxx> wrote:
>
> HasApply is more grammatical. But I like having the naming
> follow the pattern of
>
> PCXXYY
> PCXXYYzz
> PCXXYYww
>
> rather than PCzzXXYY, or PCwwXXYY etc.
>
> That is as much of the strings should start the same way for
> related routines. Hence PCApplyRichardsonExists() is
> near PCApplyRichardson() while PCHasApplyRichardson()
> is kilometers away.
>
> Barry
>
> Hence we have
> KSPMonitor()
> KSPMonitorSet()
> KSPMonitorCancel()
> KSPMonitorSingularValue()
> KSPMonitorDefault()
> I realize the KSPMonitorSet() instead of KSPSetMonitor() is non-standard but
> that doesn't mean it is wrong :-).
>
> Essentially when you sort the function names, I'd like the related ones
> together.
>
>
> On Tue, 9 Oct 2007, Lisandro Dalcin wrote:
>
> > Which form should be the preferred one? I'm inclined for the fist...
> >
> > PetscErrorCode PCHasApplyTranspose(PC,PetscTruth*)
> > PetscErrorCode PCApplyRichardsonExists(PC,PetscTruth*)
> >
> >
> >
>
>
--
Lisandro Dalcín
---------------
Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
PTLC - Güemes 3450, (3000) Santa Fe, Argentina
Tel/Fax: +54-(0)342-451.1594