[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
finished changes for solving strict aliasing issue
- To: petsc-dev@xxxxxxxxxxx
- Subject: finished changes for solving strict aliasing issue
- From: "Lisandro Dalcin" <dalcinl@xxxxxxxxx>
- Date: Tue, 2 Oct 2007 15:03:39 -0300
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=PJLlXxu9DKvHfmWqYit1Ke4HEY6JCbooGFEI0zNCO30=; b=cIkMp4RLWM/TOKqf8MqwcEqoxoKn96RGuxPmhRtr+RZA9SCWa8blGkPuiyke6VDOpKewrfcewIEDZIewvfhy4nUONfLloe5ipJKWPRNu115Uo03GigfGSvBM+Wu8qNBhyKRYdvO/HWrfvhI7kv9DVwuPvUPTLRzFEEV5euV+dcY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=rd8WyKGfupvlp83sYohIEZDBHZyas54mS+lVg9vCLZJ1AOC4YT237foE5Irdt/N3VpstCTEdbvujTPBy+MNNYJa3pkrIDNaV4HqadFB58yZXRyRoKJ5OTcn6SAXBBBhJjO/XkPMdfHh+W9sMSEuyf9xZYp6nc5w+XHsNfSGqiBQ=
- Reply-to: petsc-dev@xxxxxxxxxxx
- Sender: owner-petsc-dev@xxxxxxxxxxx
Not sure if any of you had the time to look at the small example I sended
to show the strict aliasing issue.
Anyway, I finished the changes needed to solve this issue, all C and
Fortran examples pass. If -Wno-strict-aliasing is removed, GCC will
still complain in many parts, but now we are sure that it will not
generate bad code when using PetscObject and derived structures. BTW,
I commented out all thos XXX_Publish() routines. Is this feature used
in any way? perhaps some external code? If this still have to be
supported, perhaps I can change PetscHeaderCreate() to pass the
publish routine.
Could you create a petsc-dev clone in the hg server in order I can
push this for your to review?
Regards,
PD: Many thanks to Stephan for his 'sed' tip. It was of great help for
this to be finished.
--
Lisandro Dalcín
---------------
Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC)
Instituto de Desarrollo Tecnológico para la Industria Química (INTEC)
Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET)
PTLC - Güemes 3450, (3000) Santa Fe, Argentina
Tel/Fax: +54-(0)342-451.1594