[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: changes to MatSetOption() in petsc-dev



On 7/9/07, Barry Smith <bsmith@xxxxxxxxxxx> wrote:
I have pushed a change to the MatSetOption() function.

Barry, a couple of comments

* I think MAT_NO_NEW_NONZERO_LOCATIONS should be
MAT_NEW_NONZERO_LOCATIONS, for symmetry with the other option names.

* I think all the MAT_INODE_LIMIT_[1..5] could be perhaps removed from
MatOption, and add a new function MatSetInodeLimit(Mat A, PetscInt
limit). Not sure what to do with  MAT_USE_INODE. Perhpas it can be
also removed, and use the previous function (with limit==0, no inodes,
and with 1 <= limit <=5, use inodes with that limit)

* You removed the MAT_[ROW|COLUMN]_SORTED stuff. I think you should
keep it, even when this feature is not yet implemented.


-- Lisandro Dalcín --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594